Issue 8422005: Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods.

Issue 8422005: Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods. (Closed)

Created:
9 years, 1 month ago by ngeoffray

Modified:
9 years, 1 month ago

Reviewers:
floitsch, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods. Committed: https://code.google.com/p/dart/source/detail?r=941

Patch Set 3 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -124 lines)			Patch
M	client/touch/TouchHandler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/lib/implementation/array.dart	View	1 2	2 chunks	+4 lines, -13 lines	0 comments	Download
M	corelib/src/list.dart	View		2 chunks	+0 lines, -20 lines	0 comments	Download
M	runtime/lib/array.dart	View		2 chunks	+8 lines, -2 lines	2 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
D	tests/corelib/src/ListFromListTest.dart	View		1 chunk	+0 lines, -87 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. http://codereview.chromium.org/8422005/diff/2001/compiler/lib/implementation/array.dart File compiler/lib/implementation/array.dart (right): http://codereview.chromium.org/8422005/diff/2001/compiler/lib/implementation/array.dart#newcode14 compiler/lib/implementation/array.dart:14: factory List<E>.fromList(List<E> other, int startIndex, int endIndex) { ...

9 years, 1 month ago (2011-10-31 09:40:44 UTC) #2

ngeoffray

Thanks! http://codereview.chromium.org/8422005/diff/2001/compiler/lib/implementation/array.dart File compiler/lib/implementation/array.dart (right): http://codereview.chromium.org/8422005/diff/2001/compiler/lib/implementation/array.dart#newcode14 compiler/lib/implementation/array.dart:14: factory List<E>.fromList(List<E> other, int startIndex, int endIndex) { ...

9 years, 1 month ago (2011-10-31 09:47:45 UTC) #3

Ivan Posva

-Ivan http://codereview.chromium.org/8422005/diff/2002/runtime/lib/array.dart File runtime/lib/array.dart (right): http://codereview.chromium.org/8422005/diff/2002/runtime/lib/array.dart#newcode15 runtime/lib/array.dart:15: factory List.fromList(List<T> other, int startIndex, int endIndex) { ...

9 years, 1 month ago (2011-11-02 23:44:07 UTC) #4

ngeoffray

9 years, 1 month ago (2011-11-03 07:54:04 UTC) #5

http://codereview.chromium.org/8422005/diff/2002/runtime/lib/array.dart
File runtime/lib/array.dart (right):

http://codereview.chromium.org/8422005/diff/2002/runtime/lib/array.dart#newco...
runtime/lib/array.dart:15: factory List.fromList(List<T> other, int startIndex,
int endIndex) {
On 2011/11/02 23:44:07, Ivan Posva wrote:
> Since you are cleaning up, please do not forget these unreachable
constructors.
> 
> Thanks!

Good catch! Follow up CL: http://codereview.chromium.org/8440062/

Expand Messages | Collapse Messages