Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods.

runtime/lib/array.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ListFactory<T> {
 
   factory List.from(Iterable<T> other) {
     GrowableObjectArray<T> list = new GrowableObjectArray<T>();
     for (final e in other) {
       list.add(e);
     }
     return list;
   }
 
   factory List.fromList(List<T> other, int startIndex, int endIndex) {

[Ivan Posva, 2011/11/02 23:44:07]

Since you are cleaning up, please do not forget these unreachable constructors.

Thanks!

[ngeoffray, 2011/11/03 07:54:04]

Good catch! Follow up CL: http://codereview.chromium.org/8440062/

     List list = new List<T>();
     if (endIndex > other.length) endIndex = other.length;
     if (startIndex < 0) startIndex = 0;
     int count = endIndex - startIndex;
     if (count > 0) {
       list.length = count;
       Arrays.copy(other, startIndex, list, 0, count);
     }
     return list;
   }
@@ skipping 49 matching lines @@
   }
 
   void insertRange(int start, int length, [T initialValue = null]) {
     throw const UnsupportedOperationException(
         "Cannot insert range in a non-extendable array");
   }
 
   List<T> getRange(int start, int length) {
     if (length == 0) return [];
     Arrays.rangeCheck(this, start, length);
-    return new List<T>.fromList(this, start, start + length);
+    List list = new List<T>();
+    list.length = length;
+    Arrays.copy(this, start, list, 0, length);
+    return list;
   }
 
   /**
    * Collection interface.
    */
 
   void forEach(f(T element)) {
     Collections.forEach(this, f);
   }
 
@@ skipping 98 matching lines @@
   }
 
   void insertRange(int start, int length, [T initialValue = null]) {
     throw const UnsupportedOperationException(
         "Cannot insert range in an immutable array");
   }
 
   List<T> getRange(int start, int length) {
     if (length == 0) return [];
     Arrays.rangeCheck(this, start, length);
-    return new List<T>.fromList(this, start, start + length);
+    List list = new List<T>();
+    list.length = length;
+    Arrays.copy(this, start, list, 0, length);
+    return list;
   }
 
   /**
    * Collection interface.
    */
 
   void forEach(f(T element)) {
     Collections.forEach(this, f);
   }
 
@@ skipping 84 matching lines @@
     if (!hasNext()) {
       throw const NoMoreElementsException();
     }
     return _array[_pos++];
   }
 
   final List<T> _array;
   final int _length;  // Cache array length for faster access.
   int _pos;
 }