Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: compiler/lib/implementation/array.dart

Issue 8422005: Remove List.fromList constructor, and List.copyFrom. They are duplicates of the new range methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/lib/implementation/array.dart
===================================================================
--- compiler/lib/implementation/array.dart (revision 938)
+++ compiler/lib/implementation/array.dart (working copy)
@@ -11,18 +11,6 @@
return list;
}
- factory List<E>.fromList(List<E> other, int startIndex, int endIndex) {
- List list = new List<E>();
- if (endIndex > other.length) endIndex = other.length;
- if (startIndex < 0) startIndex = 0;
- int count = endIndex - startIndex;
- if (count > 0) {
- list.length = count;
- Arrays.copy(other, startIndex, list, 0, count);
- }
- return list;
- }
-
factory List<E>([int length = null]) {
bool isFixed = true;
if (length === null) {
@@ -153,7 +141,10 @@
List<T> getRange(int start, int length) {
if (length == 0) return [];
Arrays.rangeCheck(this, start, length);
- return new List<T>.fromList(this, start, start + length);
+ List list = new List<T>();
+ list.length = length;
+ Arrays.copy(this, start, list, 0, length);
+ return list;
}
int indexOf(T element, int startIndex) {
« no previous file with comments | « client/touch/TouchHandler.dart ('k') | corelib/src/list.dart » ('j') | runtime/lib/array.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698