Use strict equality when comparing with null, especially when null is a default value.

Use strict equality when comparing with null, especially when null is a default value.
Committed: https://code.google.com/p/dart/source/detail?r=859

[srdjan, 2011-10-27 20:47:45]

M      corelib/src/implementation/future_implementation.dart
M      runtime/lib/string.dart
M      corelib/src/expect.dart
M      corelib/src/implementation/splay_tree.dart
M      corelib/src/implementation/promise_implementation.dart
M      runtime/vm/snapshot_test.dart
M      runtime/bin/string_stream.dart
M      runtime/bin/file_impl.dart
M      runtime/bin/socket_stream.dart
M      runtime/bin/socket_impl.dart
M      runtime/bin/process_impl.dart

[siva, 2011-10-27 21:35:07]

lgtm

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/f...
File corelib/src/implementation/future_implementation.dart (right):

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/f...
corelib/src/implementation/future_implementation.dart:78: return isComplete &&
exception === null;
shouldn't this be _exception === null ?

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/s...
File corelib/src/implementation/splay_tree.dart (right):

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/s...
corelib/src/implementation/splay_tree.dart:184: while (current != null) {
should these be !==

[srdjan, 2011-10-27 21:50:11]

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/f...
File corelib/src/implementation/future_implementation.dart (right):

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/f...
corelib/src/implementation/future_implementation.dart:78: return isComplete &&
exception === null;
On 2011/10/27 21:35:07, asiva wrote:
> shouldn't this be _exception === null ?

Good catch! Obviously we do not have enough tests ;-).

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/s...
File corelib/src/implementation/splay_tree.dart (right):

http://codereview.chromium.org/8400038/diff/2001/corelib/src/implementation/s...
corelib/src/implementation/splay_tree.dart:184: while (current != null) {
On 2011/10/27 21:35:07, asiva wrote:
> should these be !==

Yes, and there are a couple more.. next CL.