Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: corelib/src/implementation/promise_implementation.dart

Issue 8400038: Use strict equality when comparing with null, especially when null is a default value. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « corelib/src/implementation/future_implementation.dart ('k') | corelib/src/implementation/splay_tree.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/promise_implementation.dart
===================================================================
--- corelib/src/implementation/promise_implementation.dart (revision 855)
+++ corelib/src/implementation/promise_implementation.dart (working copy)
@@ -161,7 +161,7 @@
if (_state == COMPLETE_NORMAL) {
completeHandler(_value);
} else if (!isDone()) {
- if (_normalListeners == null) {
+ if (_normalListeners === null) {
_normalListeners = new Queue<Function>();
}
_normalListeners.addLast(completeHandler);
@@ -172,7 +172,7 @@
if (_state == COMPLETE_ERROR) {
errorHandler(_error);
} else if (!isDone()) {
- if (_errorListeners == null) {
+ if (_errorListeners === null) {
_errorListeners = new Queue<Function>();
}
_errorListeners.addLast(errorHandler);
@@ -183,7 +183,7 @@
if (isCancelled()) {
cancelHandler();
} else if (!isDone()) {
- if (_cancelListeners == null) {
+ if (_cancelListeners === null) {
_cancelListeners = new Queue<Function>();
}
_cancelListeners.addLast(cancelHandler);
« no previous file with comments | « corelib/src/implementation/future_implementation.dart ('k') | corelib/src/implementation/splay_tree.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698