Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: corelib/src/implementation/future_implementation.dart

Issue 8400038: Use strict equality when comparing with null, especially when null is a default value. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « corelib/src/expect.dart ('k') | corelib/src/implementation/promise_implementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/future_implementation.dart
===================================================================
--- corelib/src/implementation/future_implementation.dart (revision 855)
+++ corelib/src/implementation/future_implementation.dart (working copy)
@@ -75,7 +75,7 @@
}
bool get hasValue() {
- return isComplete && exception == null;
+ return isComplete && _exception === null;
}
void then(void onComplete(T value)) {
@@ -119,7 +119,7 @@
}
void _setException(var exception) {
- if (exception == null) {
+ if (exception === null) {
// null is not a legal value for the exception of a Future
throw new IllegalArgumentException(null);
}
« no previous file with comments | « corelib/src/expect.dart ('k') | corelib/src/implementation/promise_implementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698