Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 8370031: Fix for events fired on different isolates. (Closed)

Created:
9 years, 2 months ago by vsm
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org, mattsh
Visibility:
Public.

Description

Fix for events fired on different isolates. Ensures that a DOM callback will be fired on the isolate that it originated on. BUG=5151491 TEST=https://chromereviews.googleplex.com/3624031/ Committed: https://code.google.com/p/dart/source/detail?r=798

Patch Set 1 #

Patch Set 2 : Remove Isolate.bind. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -81 lines) Patch
M client/dom/generated/wrapping_dom.js View 1 3 chunks +25 lines, -16 lines 0 comments Download
M client/dom/scripts/template_wrapping_dom.js View 1 3 chunks +25 lines, -16 lines 0 comments Download
M client/samples/dartcombat/setup.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/samples/dartcombat/views.dart View 1 3 chunks +5 lines, -8 lines 0 comments Download
M client/samples/isolate/IsolateSample.dart View 1 5 chunks +7 lines, -7 lines 0 comments Download
M client/testing/unittest/unittestsuite.dart View 1 2 chunks +3 lines, -5 lines 1 comment Download
M compiler/lib/implementation/isolate.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M compiler/lib/implementation/isolate.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M corelib/src/isolate.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsm
9 years, 2 months ago (2011-10-24 05:29:41 UTC) #1
Siggi Cherem (dart-lang)
lets also make native_IsolateNatives_bind a noop (compiler/lib/implementation/isolate.js), and run the dartcombat tests (client/samples/dartcombat) to see ...
9 years, 2 months ago (2011-10-24 20:07:13 UTC) #2
vsm
PTAL Removing Isolate.bind exposed further issues. Calling isolate$runEventLoop in the dom layer feels like a ...
9 years, 2 months ago (2011-10-25 18:44:46 UTC) #3
Siggi Cherem (dart-lang)
-floitschv8@gmail +floitsch@google lgtm I think you could also remove the 'bind' function from IsolateNatives in ...
9 years, 1 month ago (2011-10-26 19:45:38 UTC) #4
floitsch
9 years, 1 month ago (2011-10-27 11:56:04 UTC) #5
LGTM!

Powered by Google App Engine
This is Rietveld 408576698