Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: client/samples/dartcombat/views.dart

Issue 8370031: Fix for events fired on different isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove Isolate.bind. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/samples/dartcombat/views.dart
diff --git a/client/samples/dartcombat/views.dart b/client/samples/dartcombat/views.dart
index a32bbbde2494cf7c08819468d6cb2abbed788cc0..72c2cac96542b0cfcba6c77a2154ebf1cd161934 100644
--- a/client/samples/dartcombat/views.dart
+++ b/client/samples/dartcombat/views.dart
@@ -84,10 +84,8 @@ class PlaceBoatView extends View {
: super(rootNode.document), _rootNode = rootNode {}
void attach() {
- _rootNode.on.mouseDown.add(
- Isolate.bind((e) { handleMouseDown(e); }));
- _rootNode.on.mouseUp.add(
- Isolate.bind((e) { handleMouseUp(e); }));
+ _rootNode.on.mouseDown.add(handleMouseDown);
+ _rootNode.on.mouseUp.add(handleMouseUp);
}
void handleMouseDown(e) {
@@ -103,7 +101,7 @@ class PlaceBoatView extends View {
_possibleBoat = ViewUtil.createDiv(this, "icons boat2");
ViewUtil.placeNodeAt(_possibleBoat, _boatStartX, _boatStartY);
_rootNode.nodes.add(_possibleBoat);
- _moveListener = Isolate.bind((e) { handleMouseMove(e); });
+ _moveListener = handleMouseMove;
_rootNode.on.mouseMove.add(_moveListener);
e.preventDefault();
}
@@ -190,11 +188,10 @@ class EnemyGridView extends View {
"${table}<div class='notready'>ENEMY IS NOT READY</div>";
statusBar = new ShootingStatusView(state, doc);
_rootNode.nodes.add(statusBar._rootNode);
- _rootNode.on.click.add(
- Isolate.bind((Event e) {
+ _rootNode.on.click.add((Event e) {
MouseEvent mouseEvent = e;
handleClick(mouseEvent);
- }), false);
+ }, false);
}
/** Interpret clicks as a shooting action. */

Powered by Google App Engine
This is Rietveld 408576698