Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: client/testing/unittest/unittestsuite.dart

Issue 8370031: Fix for events fired on different isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove Isolate.bind. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/samples/isolate/IsolateSample.dart ('k') | compiler/lib/implementation/isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/unittestsuite.dart
diff --git a/client/testing/unittest/unittestsuite.dart b/client/testing/unittest/unittestsuite.dart
index fde5b2e39d0fd06f4233c3851e1777caa0e841f1..3e7bfa85ca9432a52d4204bcd75cce7cdfd81c36 100644
--- a/client/testing/unittest/unittestsuite.dart
+++ b/client/testing/unittest/unittestsuite.dart
@@ -116,10 +116,8 @@ class UnitTestSuite {
/** Runs all queued tests, one at a time. */
void runTests() {
- window.dynamic/*TODO(5389254)*/.postMessage('unittest-suite-start', '*');
- // Isolate.bind makes sure the closure runs in the same isolate (i.e. this
- // one) where it has been created.
- window.setTimeout(Isolate.bind(() {
+ window.postMessage('unittest-suite-start', '*');
+ window.setTimeout(() {
assert (_currentTest == 0);
// Listen for uncaught errors (see [_uncaughtError]).
// TODO(jacobr): remove this horrible hack when dartc bugs are fixed.
@@ -129,7 +127,7 @@ class UnitTestSuite {
window.dynamic.onerror = _onErrorClosure;
}
_nextBatch();
- }), 0);
+ }, 0);
Siggi Cherem (dart-lang) 2011/10/26 19:45:38 << (fix indent)
}
void _onError(e) {
« no previous file with comments | « client/samples/isolate/IsolateSample.dart ('k') | compiler/lib/implementation/isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698