Issue 8357034: Transitioning to new IC structure: change IC data to include function name; pass IC data instead ...

Issue 8357034: Transitioning to new IC structure: change IC data to include function name; pass IC data instead ... (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Transitioning to new IC structure: change IC data to include function name; pass IC data instead of function name when calling instance function. New IC doc: http://goo.gl/fS2Hk Committed: https://code.google.com/p/dart/source/detail?r=636

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 8

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+318 lines, -360 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3 4 5	7 chunks	+15 lines, -8 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4 5	4 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	1 2 3 4 5	4 chunks	+8 lines, -6 lines	0 comments	Download
A	runtime/vm/ic_data.h	View	1 2 3 4	1 chunk	+78 lines, -0 lines	0 comments	Download
A	runtime/vm/ic_data.cc	View	1 2 3 4	1 chunk	+103 lines, -0 lines	0 comments	Download
A	runtime/vm/ic_data_test.cc	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download
M	runtime/vm/ic_stubs.h	View	1 2 3 4 5	1 chunk	+0 lines, -49 lines	0 comments	Download
D	runtime/vm/ic_stubs.cc	View	1 2 3 4 5	1 chunk	+0 lines, -157 lines	0 comments	Download
M	runtime/vm/ic_stubs_ia32.cc	View	1 2 3 4 5	3 chunks	+0 lines, -22 lines	0 comments	Download
M	runtime/vm/ic_stubs_ia32_test.cc	View	1 2 3 4 5	1 chunk	+0 lines, -87 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	19 chunks	+29 lines, -26 lines	0 comments	Download
	runtime/vm/vm_sources.gypi	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.cc File runtime/vm/ic_data.cc (right): http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.cc#newcode65 runtime/vm/ic_data.cc:65: &Array::ZoneHandle(Array::Grow(*data_, new_len, Heap::kOld)); Should fit on one line. ...

9 years, 2 months ago (2011-10-21 03:03:52 UTC) #2

srdjan

9 years, 2 months ago (2011-10-22 07:48:53 UTC) #3

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.cc
File runtime/vm/ic_data.cc (right):

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.cc#newcode65
runtime/vm/ic_data.cc:65: &Array::ZoneHandle(Array::Grow(*data_, new_len,
Heap::kOld));
On 2011/10/21 03:03:52, regis wrote:
> Should fit on one line.

Done.

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.cc#newcode79
runtime/vm/ic_data.cc:79: // Contract says that no null classes may be added.
On 2011/10/21 03:03:52, regis wrote:
> There is only one Null class. How about
> // Contract says that the class of null (NullClass) cannot be added.

Done.

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.h
File runtime/vm/ic_data.h (right):

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.h#newcode6
runtime/vm/ic_data.h:6: // At instance call the ECX register contains the
IC-data array.
On 2011/10/21 03:03:52, regis wrote:
> This header is not ia32 specific, so I would write:
> // The caller of an instance function passes the IC-data array in a specific
> register (ECX on ia32).

Done.

http://codereview.chromium.org/8357034/diff/33/runtime/vm/ic_data.h#newcode17
runtime/vm/ic_data.h:17: // Array is terminated with a nulled check (all classes
and target are NULL).
On 2011/10/21 03:03:52, regis wrote:
> Array is null terminated (all ...

Done.

Expand Messages | Collapse Messages