Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1932)

Unified Diff: runtime/vm/ic_stubs_ia32.cc

Issue 8357034: Transitioning to new IC structure: change IC data to include function name; pass IC data instead ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ic_stubs.cc ('k') | runtime/vm/ic_stubs_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ic_stubs_ia32.cc
===================================================================
--- runtime/vm/ic_stubs_ia32.cc (revision 633)
+++ runtime/vm/ic_stubs_ia32.cc (working copy)
@@ -193,14 +193,6 @@
Instructions& inst = Instructions::Handle(
Instructions::FromEntryPoint(ic_entry_point));
ASSERT(!inst.IsNull());
- ICData ic_data(Code::Handle(inst.code()));
- if (patch_code) {
- const Function& from_function =
- Function::Handle(ci_table->LookupFunction(from));
- const Function& to_function =
- Function::Handle(ci_table->LookupFunction(to));
- ic_data.ChangeTargets(from_function, to_function);
- }
if (!StubCode::InCallInstanceFunctionStubCode(test_smi.TargetAddress())) {
// Jump is an IC success.
@@ -234,12 +226,6 @@
ICCheckReceiverClass check_class(instruction_address);
if (!check_class.IsValid()) {
// Done parsing.
-#if defined(DEBUG)
- // Classes can be set to NULL if we do not care about collecting them.
- if (classes != NULL) {
- ic_data.CheckIsSame(classes, targets);
- }
-#endif
return true;
}
if (patch_code && (check_class.TargetAddress() == from)) {
@@ -362,14 +348,6 @@
OS::Print("}\n");
}
- ICData ic_data(ic_stub_code);
- ic_data.SetICDataArray(1, classes.length());
- ASSERT(classes.length() == targets.length());
- for (intptr_t i = 0; i < classes.length(); i++) {
- GrowableArray<const Class*> temp_classes;
- temp_classes.Add(classes[i]);
- ic_data.SetCheckAt(i, temp_classes, *(targets[i]));
- }
return ic_stub_code.raw();
#undef __
}
« no previous file with comments | « runtime/vm/ic_stubs.cc ('k') | runtime/vm/ic_stubs_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698