Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: runtime/vm/code_patcher_ia32.cc

Issue 8357034: Transitioning to new IC structure: change IC data to include function name; pass IC data instead ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/ic_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_ia32.cc
===================================================================
--- runtime/vm/code_patcher_ia32.cc (revision 633)
+++ runtime/vm/code_patcher_ia32.cc (working copy)
@@ -8,6 +8,7 @@
#include "vm/assembler.h"
#include "vm/code_patcher.h"
#include "vm/cpu.h"
+#include "vm/ic_data.h"
#include "vm/instructions.h"
#include "vm/object.h"
#include "vm/raw_object.h"
@@ -107,7 +108,7 @@
// The expected pattern of a dart instance call:
-// mov ECX, function_name
+// mov ECX, ic-data array
// mov EDX, argument_descriptor_array
// call target_address
// <- return address
@@ -116,10 +117,10 @@
explicit InstanceCall(uword return_address)
: DartCallPattern(return_address) {}
- RawString* function_name() const {
- String& str = String::Handle();
- str ^= reinterpret_cast<RawObject*>(immediate_one());
- return str.raw();
+ RawArray* ic_data() const {
+ Array& array = Array::Handle();
+ array ^= reinterpret_cast<RawObject*>(immediate_one());
+ return array.raw();
}
private:
@@ -244,7 +245,8 @@
*num_arguments = call.argument_count();
*num_named_arguments = call.named_argument_count();
*target = call.target();
- *function_name = call.function_name();
+ ICData ic_data(Array::ZoneHandle(call.ic_data()));
+ *function_name = ic_data.FunctionName();
}
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/ic_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698