Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 8348016: Clean up observable tests to new API. (Closed)

Created:
9 years, 2 months ago by Bob Nystrom
Modified:
9 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up observable tests to new API. Committed: https://code.google.com/p/dart/source/detail?r=539

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add comment about architecture.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -168 lines) Patch
M client/tests/client/observable/AbstractObservableTests.dart View 2 chunks +37 lines, -47 lines 0 comments Download
M client/tests/client/observable/ChangeEventTests.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M client/tests/client/observable/EventBatchTests.dart View 2 chunks +9 lines, -27 lines 0 comments Download
M client/tests/client/observable/ObservableListTests.dart View 4 chunks +20 lines, -27 lines 0 comments Download
D client/tests/client/observable/ObservableTestSetBase.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M client/tests/client/observable/ObservableValueTests.dart View 3 chunks +6 lines, -15 lines 0 comments Download
M client/tests/client/observable/observable_tests.dart View 1 2 chunks +30 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
9 years, 2 months ago (2011-10-18 21:53:09 UTC) #1
Jennifer Messerly
btw, this new style looks awesome! http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/AbstractObservableTests.dart File client/tests/client/observable/AbstractObservableTests.dart (right): http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/AbstractObservableTests.dart#newcode23 client/tests/client/observable/AbstractObservableTests.dart:23: expect(target.listeners).equalsCollection([]); Could this ...
9 years, 2 months ago (2011-10-18 21:56:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm very nice! http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/observable_tests.dart File client/tests/client/observable/observable_tests.dart (right): http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/observable_tests.dart#newcode7 client/tests/client/observable/observable_tests.dart:7: #import('dart:html'); let's add a TODO on ...
9 years, 2 months ago (2011-10-18 22:10:11 UTC) #3
Bob Nystrom
http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/observable_tests.dart File client/tests/client/observable/observable_tests.dart (right): http://codereview.chromium.org/8348016/diff/1/client/tests/client/observable/observable_tests.dart#newcode7 client/tests/client/observable/observable_tests.dart:7: #import('dart:html'); On 2011/10/18 22:10:11, sigmund wrote: > let's add ...
9 years, 2 months ago (2011-10-18 22:20:35 UTC) #4
Bob Nystrom
9 years, 2 months ago (2011-10-18 22:23:53 UTC) #5
Tanks!

Powered by Google App Engine
This is Rietveld 408576698