Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: client/tests/client/observable/EventBatchTests.dart

Issue 8348016: Clean up observable tests to new API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add comment about architecture.py. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/tests/client/observable/EventBatchTests.dart
diff --git a/client/tests/client/observable/EventBatchTests.dart b/client/tests/client/observable/EventBatchTests.dart
index 515f72cc71f7c18556ab0fe0e8bb285facd5bf94..23b0f9f7e9a7ac2bb1a128dfab8ac6e23f7a162b 100644
--- a/client/tests/client/observable/EventBatchTests.dart
+++ b/client/tests/client/observable/EventBatchTests.dart
@@ -2,15 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class EventBatchTests extends ObservableTestSetBase {
- // TODO(rnystrom): Remove this when default constructors are supported.
- EventBatchTests() : super();
-
- setup() {
- addTest(testEventBatch);
- }
-
- void testEventBatch() {
+testEventBatch() {
+ test('EventBatch', () {
// check that all events are fired at the end. Use all record methods
// in abstract observable
final target = new AbstractObservable();
@@ -35,22 +28,11 @@ class EventBatchTests extends ObservableTestSetBase {
expect(res).isNotNull();
expect(res.events.length).equals(6);
- checkEvent(res.events[0],
- target, 'pM', null, ChangeEvent.UPDATE, 10, 11);
-
- checkEvent(res.events[1],
- target, 'pL', null, ChangeEvent.UPDATE, '11', '13');
-
- checkEvent(res.events[2],
- target, null, 2, ChangeEvent.UPDATE, 'a', 'b');
-
- checkEvent(res.events[3],
- target, null, 5, ChangeEvent.INSERT, 'a', null);
-
- checkEvent(res.events[4],
- target, null, 4, ChangeEvent.REMOVE, null, 'c');
-
- checkEvent(res.events[5],
- target, null, null, ChangeEvent.GLOBAL, null, null);
- }
+ validateUpdate(res.events[0], target, 'pM', null, 10, 11);
+ validateUpdate(res.events[1], target, 'pL', null, '11', '13');
+ validateUpdate(res.events[2], target, null, 2, 'a', 'b');
+ validateInsert(res.events[3], target, null, 5, 'a');
+ validateRemove(res.events[4], target, null, 4, 'c');
+ validateGlobal(res.events[5], target);
+ });
}
« no previous file with comments | « client/tests/client/observable/ChangeEventTests.dart ('k') | client/tests/client/observable/ObservableListTests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698