Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: client/tests/client/observable/ChangeEventTests.dart

Issue 8348016: Clean up observable tests to new API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add comment about architecture.py. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/tests/client/observable/ChangeEventTests.dart
diff --git a/client/tests/client/observable/ChangeEventTests.dart b/client/tests/client/observable/ChangeEventTests.dart
index 1ae12b47490649e56e0aa3fc46534587f2b922ad..a59ce87d75347318dfeb1000a661715c71096561 100644
--- a/client/tests/client/observable/ChangeEventTests.dart
+++ b/client/tests/client/observable/ChangeEventTests.dart
@@ -2,31 +2,29 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class ChangeEventTests extends ObservableTestSetBase {
- // TODO(rnystrom): Remove this when default constructors are supported.
- ChangeEventTests() : super();
-
- setup() {
- addTest(testChangeEventConstructors);
- }
-
- void testChangeEventConstructors() {
+testChangeEvent() {
+ test('constructor', () {
// create property, list, global and check the proper initialization.
final target = new AbstractObservable();
- checkEvent(new ChangeEvent.property(target, 'pK', 33, '12'),
- target, 'pK', null, ChangeEvent.UPDATE, 33, '12');
+ validateUpdate(
+ new ChangeEvent.property(target, 'pK', 33, '12'),
+ target, 'pK', null, 33, '12');
- checkEvent(new ChangeEvent.list(target, ChangeEvent.UPDATE, 3, 33, '12'),
- target, null, 3, ChangeEvent.UPDATE, 33, '12');
+ validateUpdate(
+ new ChangeEvent.list(target, ChangeEvent.UPDATE, 3, 33, '12'),
+ target, null, 3, 33, '12');
- checkEvent(new ChangeEvent.list(target, ChangeEvent.INSERT, 3, 33, null),
- target, null, 3, ChangeEvent.INSERT, 33, null);
+ validateInsert(
+ new ChangeEvent.list(target, ChangeEvent.INSERT, 3, 33, null),
+ target, null, 3, 33);
- checkEvent(new ChangeEvent.list(target, ChangeEvent.REMOVE, 3, null, '12'),
- target, null, 3, ChangeEvent.REMOVE, null, '12');
+ validateRemove(
+ new ChangeEvent.list(target, ChangeEvent.REMOVE, 3, null, '12'),
+ target, null, 3, '12');
- checkEvent(new ChangeEvent.list(target, ChangeEvent.GLOBAL, 0, null, null),
- target, null, 0, ChangeEvent.GLOBAL, null, null);
- }
+ validateGlobal(
+ new ChangeEvent.list(target, ChangeEvent.GLOBAL, null, null, null),
+ target);
+ });
}
« no previous file with comments | « client/tests/client/observable/AbstractObservableTests.dart ('k') | client/tests/client/observable/EventBatchTests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698