Issue 8334035: Reduces code generated by dynamic calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8334035: Reduces code generated by dynamic calls. (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly

Modified:
9 years, 1 month ago

Reviewers:
jimhug

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Reduces code generated by dynamic calls. Also cleans type asserts TBR=jimhug Committed: https://code.google.com/p/dart/source/detail?r=1163

Patch Set 1 #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+495 lines, -1075 lines)			Patch
M	frog/frogsh	View	107 chunks	+357 lines, -999 lines	1 comment	Download
M	frog/gen.dart	View	2 chunks	+5 lines, -3 lines	2 comments	Download
M	frog/member.dart	View	13 chunks	+64 lines, -54 lines	0 comments	Download
M	frog/type.dart	View	5 chunks	+29 lines, -0 lines	0 comments	Download
M	frog/value.dart	View	7 chunks	+40 lines, -17 lines	0 comments	Download
M	tests/language/language.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

This change takes the simplest "hi.dart" sample using the HTML library from ~200k to ~50k. ...

9 years, 1 month ago (2011-11-03 21:16:28 UTC) #1

jimhug

9 years, 1 month ago (2011-11-07 21:14:21 UTC) #2

LGTM

frogsh is 600 lines shorter with 2 more tests passing.  This is a high bar to
beat for bang-for-the-buck changes.

http://codereview.chromium.org/8334035/diff/1/frog/frogsh
File frog/frogsh (right):

http://codereview.chromium.org/8334035/diff/1/frog/frogsh#newcode17613
frog/frogsh:17613: main();
Yay! 600 fewer lines!

http://codereview.chromium.org/8334035/diff/1/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8334035/diff/1/frog/gen.dart#newcode113
frog/gen.dart:113: genMethod(Member meth, [MethodGenerator
enclosingMethod=null]) {
Nit: I like the spaces int the original enclosingMethod = null.

http://codereview.chromium.org/8334035/diff/1/frog/gen.dart#newcode1851
frog/gen.dart:1851: world.coreimpl.types['ListFactory'].markUsed();
This is getting annoying - I'm a little afraid of a death by a thousand cuts as
each manual markUsed call feels easy.  I started the trend, so just take this as
something to keep in mind for the future.

Expand Messages | Collapse Messages