Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: frog/gen.dart

Issue 8334035: Reduces code generated by dynamic calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« frog/frogsh ('K') | « frog/frogsh ('k') | frog/member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/gen.dart
diff --git a/frog/gen.dart b/frog/gen.dart
index 40830f97c31a9c1f60b786fc83814776b8c957cb..2ca3f3de6b19ca2668fb71a99bc2384952d87174 100644
--- a/frog/gen.dart
+++ b/frog/gen.dart
@@ -110,9 +110,9 @@ class WorldGenerator {
}
}
- genMethod(Member meth, [MethodGenerator enclosingMethod = null]) {
- if (!meth.isGenerated && meth.declaringType.isClass &&
- meth.definition != null && !meth.isAbstract) {
+ genMethod(Member meth, [MethodGenerator enclosingMethod=null]) {
jimhug 2011/11/07 21:14:21 Nit: I like the spaces int the original enclosingM
+ if (!meth.isGenerated && meth.declaringType.isClass
+ && meth.definition != null && !meth.isAbstract) {
new MethodGenerator(meth, enclosingMethod).run();
}
}
@@ -1848,6 +1848,8 @@ class MethodGenerator implements TreeVisitor {
}
}
+ world.coreimpl.types['ListFactory'].markUsed();
jimhug 2011/11/07 21:14:21 This is getting annoying - I'm a little afraid of
+
final code = '[${Strings.join(argsCode, ", ")}]';
var value = new Value(world.listType, code);
if (node.isConst) {
« frog/frogsh ('K') | « frog/frogsh ('k') | frog/member.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698