Reduces code generated by dynamic calls.

frog/gen.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Top level generator object for writing code and keeping track of
  * dependencies.
  *
  * Should have two compilation models, but only one implemented so far.
  *
@@ skipping 92 matching lines @@
 
         if (type.isGeneric) {
           for (var ct in _orderValues(type._concreteTypes)) {
             writeType(ct);
           }
         }
       }
     }
   }
 
-  genMethod(Member meth, [MethodGenerator enclosingMethod = null]) {
-    if (!meth.isGenerated && meth.declaringType.isClass &&
-          meth.definition != null && !meth.isAbstract) {
+  genMethod(Member meth, [MethodGenerator enclosingMethod=null]) {

[jimhug, 2011/11/07 21:14:21]

Nit: I like the spaces int the original enclosingMethod = null.

+    if (!meth.isGenerated && meth.declaringType.isClass
+        && meth.definition != null && !meth.isAbstract) {
       new MethodGenerator(meth, enclosingMethod).run();
     }
   }
 
   _maybeIsTest(Type onType, Type checkType) {
     if (!checkType.isTested) return;
 
     writer.writeln('${onType.jsname}.prototype.is\$${checkType.jsname} ='
         + ' function(){return this;};');
   }
@@ skipping 1715 matching lines @@
           world.error('const list can only contain const values', item.span);
           argsCode.add(arg.code);
         } else {
           argsCode.add(arg.canonicalCode);
         }
       } else {
         argsCode.add(arg.code);
       }
     }
 
+    world.coreimpl.types['ListFactory'].markUsed();

[jimhug, 2011/11/07 21:14:21]

This is getting annoying - I'm a little afraid of a death by a thousand cuts as
each manual markUsed call feels easy.  I started the trend, so just take this as
something to keep in mind for the future.

+
     final code = '[${Strings.join(argsCode, ", ")}]';
     var value = new Value(world.listType, code);
     if (node.isConst) {
       final immutableList = world.coreimpl.types['ImmutableList'];
       final immutableListCtor = immutableList.getConstructor('from');
       final result = immutableListCtor.invoke(
           this, node, null, new Arguments(null, [value]));
       value = world.gen.globalForConst(
           new ConstListValue(immutableList, argValues, 'const $code',
               result.code, node.span),
@@ skipping 289 matching lines @@
       result.add(new Value(world.varType, '\$$i', false, /*needsTemp:*/false));
     }
     for (int i = bareCount; i < length; i++) {
       var name = getName(i);
       if (name == null) name = '\$$i';
       result.add(new Value(world.varType, name, false, /*needsTemp:*/false));
     }
     return new Arguments(nodes, result);
   }
 }