Issue 7259010: MIPS: update missing write barrier for arguments store ICs, per comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7259010: MIPS: update missing write barrier for arguments store ICs, per comments. (Closed)

Created:
9 years, 6 months ago by Paul Lind

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, fschneider

CC:
v8-dev

Visibility:
Public.

MIPS: update missing write barrier for arguments store ICs, per comments. Per review comments in http://codereview.chromium.org/7238020 after issue was closed, we had used an un-necessary Add, which is removed here. Thanks for the suggestion. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8425

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/mips/assembler-mips.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/mips/ic-mips.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

I will commit it.