Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 7238020: MIPS: port Add missing write barrier for arguments store ICs. (Closed)

Created:
9 years, 6 months ago by Paul Lind
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Add missing write barrier for arguments store ICs. Ported r8390 (52d4605) BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8405

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/mips/ic-mips.cc View 2 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
9 years, 6 months ago (2011-06-24 05:56:04 UTC) #1
Søren Thygesen Gjesse
LGTM I will commit it.
9 years, 6 months ago (2011-06-24 08:31:57 UTC) #2
fschneider
9 years, 6 months ago (2011-06-24 09:13:38 UTC) #3
Drive-by comments. I think the code is correct, but could be improved:

http://codereview.chromium.org/7238020/diff/1/src/mips/ic-mips.cc
File src/mips/ic-mips.cc (right):

http://codereview.chromium.org/7238020/diff/1/src/mips/ic-mips.cc#newcode1009
src/mips/ic-mips.cc:1009: __ Addu(t2, a3, t1);
Since the store address is already computed by GenerateMappedArgumentsLookup
into t0, I think you could avoid this add here and just write:

__ RecordWrite(a3, t0, t5);

http://codereview.chromium.org/7238020/diff/1/src/mips/ic-mips.cc#newcode1018
src/mips/ic-mips.cc:1018: __ Addu(t2, a3, t0);
Same here. The store address is already computed into t0.

Powered by Google App Engine
This is Rietveld 408576698