Chromium Code Reviews

Issue 7062014: MIPS: Added the stop() instruction with same behavior as on Arm simulator. (Closed)

Created:
9 years, 7 months ago by Paul Lind
Modified:
9 years, 7 months ago
Reviewers:
Søren Thygesen Gjesse
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Added the stop() instruction with same behavior as on Arm simulator. The already working watchpoint break mechanism has been extended to handle "stop" instructions, with text messages. Explanation (also in constants-mips.h): On MIPS Simulator breakpoints can have different codes: - Breaks between 0 and kMaxWatchpointCode are treated as simple watchpoints, the simulator will run through them and print the registers. - Breaks between kMaxWatchpointCode and kMaxStopCode are treated as stop() instructions (see Assembler::stop()). - Breaks larger than kMaxStopCode are simple breaks, dropping you into the debugger. The current values are 31 for kMaxWatchpointCode and 127 for kMaxStopCode. From the user's point of view this works the same way as the ARM stop instruction except for the break code usage detailed above. Ported commits: r5723 (3ba78d24) BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8069

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+275 lines, -35 lines)
M src/mips/assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments
M src/mips/assembler-mips.cc View 1 chunk +25 lines, -1 line 0 comments
M src/mips/constants-mips.h View 1 chunk +12 lines, -0 lines 0 comments
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/mips/simulator-mips.h View 2 chunks +25 lines, -0 lines 1 comment
M src/mips/simulator-mips.cc View 7 chunks +211 lines, -22 lines 0 comments

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 7 months ago (2011-05-26 04:17:59 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-26 07:11:50 UTC) #2
LGTM

I will address the i -> I and commit.

http://codereview.chromium.org/7062014/diff/1/src/mips/simulator-mips.h
File src/mips/simulator-mips.h (right):

http://codereview.chromium.org/7062014/diff/1/src/mips/simulator-mips.h#newco...
src/mips/simulator-mips.h:292: // Stop helper functions.
isWatchpoint with uppercase I (two more below).

Powered by Google App Engine