Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 999943002: Revert of Remove ganesh whitelist for all Android Lollipop devices (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ganesh whitelist for all Android Lollipop devices (patchset #2 id:20001 of https://codereview.chromium.org/982153002/) Reason for revert: This unintentionally blacklisted nexus 6. Original issue's description: > Remove ganesh whitelist for all Android Lollipop devices > > Some old devices are getting lollipop update without updated drivers. > > BUG= > > Committed: https://crrev.com/9685ef41ca89943d9e918f5bd7636323bec38af0 > Cr-Commit-Position: refs/heads/master@{#319762} BUG=443060 TBR=aelias,zmo

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M gpu/config/software_rendering_list_json.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
boliu
Created Revert of Remove ganesh whitelist for all Android Lollipop devices
5 years, 9 months ago (2015-03-11 23:30:37 UTC) #1
boliu
Removed all the NOTRYs and whatnot, but question, should I bump the version, or reverting ...
5 years, 9 months ago (2015-03-11 23:31:39 UTC) #2
boliu
On 2015/03/11 23:31:39, boliu wrote: > Removed all the NOTRYs and whatnot, but question, should ...
5 years, 9 months ago (2015-03-11 23:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999943002/1
5 years, 9 months ago (2015-03-12 00:00:56 UTC) #5
vmiura
I was going to say, if we use this version number for UMA reports or ...
5 years, 9 months ago (2015-03-12 01:38:54 UTC) #6
boliu
On 2015/03/12 01:38:54, vmiura wrote: > I was going to say, if we use this ...
5 years, 9 months ago (2015-03-12 01:40:09 UTC) #8
aelias_OOO_until_Jul13
Do we know why the Nexus 6 isn't covered under the K + OpenGL ES ...
5 years, 9 months ago (2015-03-12 02:30:21 UTC) #9
vmiura
On 2015/03/12 02:30:21, aelias wrote: > Do we know why the Nexus 6 isn't covered ...
5 years, 9 months ago (2015-03-12 14:48:27 UTC) #10
boliu
On 2015/03/12 14:48:27, vmiura wrote: > On 2015/03/12 02:30:21, aelias wrote: > > Do we ...
5 years, 9 months ago (2015-03-12 16:30:09 UTC) #11
vmiura
5 years, 9 months ago (2015-03-12 17:59:50 UTC) #12
Message was sent while issue was closed.
On 2015/03/12 16:30:09, boliu wrote:
> On 2015/03/12 14:48:27, vmiura wrote:
> > On 2015/03/12 02:30:21, aelias wrote:
> > > Do we know why the Nexus 6 isn't covered under the K + OpenGL ES 3 rule?
> > 
> > Their GL version string wasn't parsed correctly.
> > 
> > Fixed here (crrev.com/999983002) so we could abandon this revert.
> 
> Thanks Victor!
> 
> I guess the question is how many devices fell into the parsing error, but was
> not on L already, which now gets ganesh whitelisted. Probably fine I imagine,
> but something to think about..

Yes, I'm going to try to get UMA stats on what devices are getting blacklisted.

Powered by Google App Engine
This is Rietveld 408576698