Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 999933005: Install warning message code for extensions that use chrome.mdns API. (Closed)

Created:
5 years, 9 months ago by Red Daly
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Install warning message code for extensions that use chrome.mdns API. BUG=451526 Committed: https://crrev.com/e143210ad4b78e93dda95d5f0ded8eec3c3effa8 Cr-Commit-Position: refs/heads/master@{#321896}

Patch Set 1 #

Patch Set 2 : Sync repository to HEAD before review #

Patch Set 3 : Restore IDS_EXTENSION_PROMPT_WARNING_MDNS message #

Total comments: 2

Patch Set 4 : Update PermissionMessage enum and corresponding xml file #

Patch Set 5 : Fix permission message unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/permission_message.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Red Daly
5 years, 9 months ago (2015-03-23 17:58:04 UTC) #1
Red Daly
Note that this code was already reviewed, but I reverted most of it before submission ...
5 years, 9 months ago (2015-03-23 18:29:54 UTC) #3
Ken Rockot(use gerrit already)
https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h File extensions/common/permissions/permission_message.h (right): https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h#newcode107 extensions/common/permissions/permission_message.h:107: kMDns, Please move this to above the preceding comment ...
5 years, 9 months ago (2015-03-23 20:35:40 UTC) #4
Red Daly
On 2015/03/23 20:35:40, Ken Rockot wrote: > https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h > File extensions/common/permissions/permission_message.h (right): > > https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h#newcode107 ...
5 years, 9 months ago (2015-03-23 20:45:11 UTC) #5
Ken Rockot(use gerrit already)
Thanks! LGTM but you will need a histograms reviewer too
5 years, 9 months ago (2015-03-23 20:46:32 UTC) #6
Red Daly
https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h File extensions/common/permissions/permission_message.h (right): https://codereview.chromium.org/999933005/diff/40001/extensions/common/permissions/permission_message.h#newcode107 extensions/common/permissions/permission_message.h:107: kMDns, On 2015/03/23 20:35:40, Ken Rockot wrote: > Please ...
5 years, 9 months ago (2015-03-23 20:48:55 UTC) #7
Red Daly
Thanks a lot for the expedited review.
5 years, 9 months ago (2015-03-23 20:51:04 UTC) #9
Ilya Sherman
histograms.xml lgtm
5 years, 9 months ago (2015-03-23 20:53:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999933005/80001
5 years, 9 months ago (2015-03-23 22:06:31 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-23 23:33:44 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 23:34:35 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e143210ad4b78e93dda95d5f0ded8eec3c3effa8
Cr-Commit-Position: refs/heads/master@{#321896}

Powered by Google App Engine
This is Rietveld 408576698