chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 999933005: Install warning message code for extensions that use chrome.mdns API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 999933005: Install warning message code for extensions that use chrome.mdns API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix permission message unit test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/templates/articles/permission_warnings.html ('k') | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 77b35bdc6facf9ae13081ea757020a73f322989d..486510c0e81da4ebcdf24a53107e5acd2a948d22 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -148,6 +148,11 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,

PermissionMessage::kManagement},

+ {APIPermission::kMDns,

+ "mdns",

+ APIPermissionInfo::kFlagCannotBeOptional,

+ IDS_EXTENSION_PROMPT_WARNING_MDNS,

+ PermissionMessage::kMDns},

{APIPermission::kNativeMessaging,

"nativeMessaging",

APIPermissionInfo::kFlagNone,

@@ -265,7 +270,6 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kMetricsPrivate,

"metricsPrivate",

APIPermissionInfo::kFlagCannotBeOptional},

- {APIPermission::kMDns, "mdns", APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kMusicManagerPrivate,

"musicManagerPrivate",

APIPermissionInfo::kFlagCannotBeOptional,