Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 999893002: Revert of Add IsAlternativeServiceBroken(), remove is_broken. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add IsAlternativeServiceBroken(), remove is_broken. (patchset #4 id:60001 of https://codereview.chromium.org/995013004/) Reason for revert: Linux bots failing with: Check failed: network_task_runner_->RunsTasksOnCurrentThread() Original issue's description: > Add IsAlternativeServiceBroken(), remove is_broken. > > Add HttpServerProperties::IsAlternativeServiceBroken(), remove > AlternateProtocolInfo.is_broken. An alternative service can be broken by > itself, not with respect to an origin. > > BUG=392576 > R=rch@chromium.org > > Committed: https://crrev.com/c0844e78ad3dd640f6a2a84f57681ead31647b07 > Cr-Commit-Position: refs/heads/master@{#320116} TBR=rch@chromium.org,bnc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392576 Committed: https://crrev.com/fe9f1976d997a6a431c012d067b1157d8b078138 Cr-Commit-Position: refs/heads/master@{#320146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -101 lines) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M net/http/http_server_properties.h View 3 chunks +18 lines, -6 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 5 chunks +15 lines, -37 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 4 chunks +28 lines, -14 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 6 chunks +5 lines, -22 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Add IsAlternativeServiceBroken(), remove is_broken.
5 years, 9 months ago (2015-03-11 21:00:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999893002/1
5 years, 9 months ago (2015-03-11 21:01:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 21:04:05 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 21:05:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe9f1976d997a6a431c012d067b1157d8b078138
Cr-Commit-Position: refs/heads/master@{#320146}

Powered by Google App Engine
This is Rietveld 408576698