Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 999873002: Move sky-*.sky into framework/elements (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move sky-*.sky into framework/elements We're not actively developing these at the moment. I could also just delete them, not sure if we're ready for that yet. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ed7395e1dcaa90703dcfe5edff303edce874ebf5

Patch Set 1 #

Patch Set 2 : One missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1284 lines) Patch
M sky/examples/custom-element/example-element.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/scrolling/scrolling.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks/stock.sky View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks/stock-arrow.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks/stocks.sky View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/examples/widgets/widget-root.sky View 4 chunks +10 lines, -10 lines 0 comments Download
A + sky/framework/elements/material-element.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/shadow.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-box.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-button.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-checkbox.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-drawer.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-drawer-header.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-element.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-icon.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-ink-splash.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-input.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-menu-divider.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-menu-item.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-radio.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-scrollable.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/framework/elements/sky-toolbar.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/framework/material-element.sky View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/framework/shadow.sky View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/framework/sky-box.sky View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/framework/sky-button.sky View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/framework/sky-checkbox.sky View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/framework/sky-drawer.sky View 1 chunk +0 lines, -166 lines 0 comments Download
D sky/framework/sky-drawer-header.sky View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/framework/sky-element.sky View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/framework/sky-icon.sky View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/framework/sky-ink-splash.sky View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/framework/sky-input.sky View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/framework/sky-menu-divider.sky View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/framework/sky-menu-item.sky View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/framework/sky-radio.sky View 1 chunk +0 lines, -112 lines 0 comments Download
D sky/framework/sky-scrollable.sky View 1 chunk +0 lines, -162 lines 0 comments Download
D sky/framework/sky-toolbar.sky View 1 chunk +0 lines, -32 lines 0 comments Download
M sky/tests/framework/binding.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/framework/observe.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/framework/templates.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/resources/test-element.sky View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 9 months ago (2015-03-11 20:46:02 UTC) #1
eseidel
Committed patchset #2 (id:20001) manually as ed7395e1dcaa90703dcfe5edff303edce874ebf5 (presubmit successful).
5 years, 9 months ago (2015-03-11 20:50:14 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-11 20:55:20 UTC) #3
Message was sent while issue was closed. 
rslgtm

Powered by Google App Engine
This is Rietveld 408576698