Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 999423004: Drive overscroll animations with a physics simulation (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Drive overscroll animations with a physics simulation This CL uses a simple physics simulation to drive overscroll animations. We model settling the overscroll as a particle climbing a hill, which gives us a pleasing parabolic trajectory. This CL also includes machinery for spring-based simulations. We'll use these to drive the drawer animation. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0a2c60a037924a179b3b82f1cc7cd8a7db5ad0b4

Patch Set 1 #

Patch Set 2 : Works #

Patch Set 3 : Remove extra files #

Patch Set 4 : More comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -33 lines) Patch
M sky/framework/animation/generator.dart View 2 chunks +12 lines, -4 lines 0 comments Download
A sky/framework/animation/kinematics.dart View 1 2 3 1 chunk +126 lines, -0 lines 0 comments Download
M sky/framework/animation/scroll_curve.dart View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
A sky/framework/animation/simulation.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M sky/framework/components/scrollable.dart View 7 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-13 08:03:27 UTC) #2
eseidel
lgtm
5 years, 9 months ago (2015-03-13 14:54:42 UTC) #3
eseidel
This is great!
5 years, 9 months ago (2015-03-13 14:54:48 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-13 16:31:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0a2c60a037924a179b3b82f1cc7cd8a7db5ad0b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698