tools/telemetry/telemetry/page/actions/action_runner.py - Issue 999243003: Adding tests for diagonal scrolling in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner.py

Issue 999243003: Adding tests for diagonal scrolling in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating the version number to the version of the Chromium binary which supports diagonal scrolling. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/page_sets/tough_scrolling_while_zoomed_in_cases.py ('K') | « tools/telemetry/telemetry/core/browser_info.py ('k') | tools/telemetry/telemetry/page/actions/scroll.js » ('j') | tools/telemetry/telemetry/page/actions/scroll.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/action_runner.py

diff --git a/tools/telemetry/telemetry/page/actions/action_runner.py b/tools/telemetry/telemetry/page/actions/action_runner.py

index f4a921856cd8282dbf6a2a167ab7c42211265bc0..d148988061c8073e486d95353852eaaa2ed561c0 100644

--- a/tools/telemetry/telemetry/page/actions/action_runner.py

+++ b/tools/telemetry/telemetry/page/actions/action_runner.py

@@ -345,7 +345,7 @@ class ActionRunner(object):

gesture, as a ratio of the visible bounding rectangle for

document.body.

direction: The direction of scroll, either 'left', 'right',

- 'up', or 'down'

+ 'up', 'down', 'upleft', 'upright', 'downleft', or 'downright'

distance: The distance to scroll (in pixel).

distance_expr: A JavaScript expression (as string) that can be

evaluated to compute scroll distance. Example:

@@ -385,7 +385,7 @@ class ActionRunner(object):

gesture, as a ratio of the visible bounding rectangle for

the element.

direction: The direction of scroll, either 'left', 'right',

- 'up', or 'down'

+ 'up', 'down', 'upleft', 'upright', 'downleft', or 'downright'

distance: The distance to scroll (in pixel).

distance_expr: A JavaScript expression (as string) that can be

evaluated to compute scroll distance. Example:

@@ -419,7 +419,7 @@ class ActionRunner(object):

gesture, as a ratio of the visible bounding rectangle for

document.body.

direction: The direction of scroll, either 'left', 'right',

- 'up', or 'down'

+ 'up', 'down', 'upleft', 'upright', 'downleft', or 'downright'

distance: The distance to scroll (in pixel).

overscroll: The number of additional pixels to scroll back, in

addition to the givendistance.

@@ -457,7 +457,7 @@ class ActionRunner(object):

gesture, as a ratio of the visible bounding rectangle for

document.body.

direction: The direction of scroll, either 'left', 'right',

- 'up', or 'down'

+ 'up', 'down', 'upleft', 'upright', 'downleft', or 'downright'

distance: The distance to scroll (in pixel).

overscroll: The number of additional pixels to scroll back, in

addition to the givendistance.