tools/telemetry/telemetry/core/browser_info.py - Issue 999243003: Adding tests for diagonal scrolling in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_info.py

Issue 999243003: Adding tests for diagonal scrolling in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating the version number to the version of the Chromium binary which supports diagonal scrolling. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/browser_info.py

diff --git a/tools/telemetry/telemetry/core/browser_info.py b/tools/telemetry/telemetry/core/browser_info.py

index 711a17bff534b939965a881a21d23890ad632319..979df1c5e003d82a17ac8686f1e7334cb50847fb 100644

--- a/tools/telemetry/telemetry/core/browser_info.py

+++ b/tools/telemetry/telemetry/core/browser_info.py

@@ -36,3 +36,10 @@ class BrowserInfo(object):

tab = self._browser.tabs[0]

result = tab.EvaluateJavaScript(_check_webgl_supported_script)

return result

+ def HasDiagonalScrollingSupport(self):

+ # Diagonal scrolling was not supported in the ScrollAction until

+ # Chromium branch number 2332

+ branch_num = self._browser._browser_backend.devtools_client \

+ .GetChromeBranchNumber()

+ return branch_num >= 2332