Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5714)

Unified Diff: content/renderer/media/media_stream_audio_processor_options.cc

Issue 999203003: content/renderer/media/: Change when to populate WebRTC.AecDelayBasedQuality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_options.cc
diff --git a/content/renderer/media/media_stream_audio_processor_options.cc b/content/renderer/media/media_stream_audio_processor_options.cc
index 2a8eb5f35a8e8c89ce8a1ad7a6a521811c0db049..5c1d45c4196f0e6c62fc5d01b4f4931f237e0912 100644
--- a/content/renderer/media/media_stream_audio_processor_options.cc
+++ b/content/renderer/media/media_stream_audio_processor_options.cc
@@ -249,12 +249,13 @@ void EchoInformation::UpdateAecDelayStats(
&dummy_median, &dummy_std, &fraction_poor_delays) ==
webrtc::AudioProcessing::kNoError) {
num_chunks_ = 0;
+ // Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
+ // histogram. See DelayBasedEchoQuality for information on histogram
+ // buckets.
+ UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
perkj_chrome 2015/03/27 09:34:09 So you no longer want to log when GetDelayMetrics
bjornv 2015/03/27 10:01:53 That's a good point. I'll remember that one if we'
+ EchoDelayFrequencyToQuality(fraction_poor_delays),
+ DELAY_BASED_ECHO_QUALITY_MAX);
}
- // Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
- // histogram. See DelayBasedEchoQuality for information on histogram buckets.
- UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
- EchoDelayFrequencyToQuality(fraction_poor_delays),
- DELAY_BASED_ECHO_QUALITY_MAX);
}
void EnableEchoCancellation(AudioProcessing* audio_processing) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698