content/renderer/media/: Change when to populate WebRTC.AecDelayBasedQuality

content/renderer/media/media_stream_audio_processor_options.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_audio_processor_options.h"
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 231 matching lines @@
   if (num_chunks_ < kNumChunksInFiveSeconds) {
     return;
   }
 
   int dummy_median = 0, dummy_std = 0;
   float fraction_poor_delays = 0;
   if (echo_cancellation->GetDelayMetrics(
           &dummy_median, &dummy_std, &fraction_poor_delays) ==
       webrtc::AudioProcessing::kNoError) {
     num_chunks_ = 0;
+    // Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
+    // histogram. See DelayBasedEchoQuality for information on histogram
+    // buckets.
+    UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",

[perkj_chrome, 2015/03/27 09:34:09]

So you no longer want to log when GetDelayMetrics fails? 

[bjornv, 2015/03/27 10:01:53]

That's a good point. I'll remember that one if we're changing the behavior in
the future.
Anyhow, right now a failure is logged as "Great AEC quality", which actually is
unknown.

+                              EchoDelayFrequencyToQuality(fraction_poor_delays),
+                              DELAY_BASED_ECHO_QUALITY_MAX);
   }
-  // Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
-  // histogram. See DelayBasedEchoQuality for information on histogram buckets.
-  UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
-                            EchoDelayFrequencyToQuality(fraction_poor_delays),
-                            DELAY_BASED_ECHO_QUALITY_MAX);
 }
 
 void EnableEchoCancellation(AudioProcessing* audio_processing) {
 #if defined(OS_ANDROID) || defined(OS_IOS)
   const std::string group_name =
       base::FieldTrialList::FindFullName("ReplaceAECMWithAEC");
   if (group_name.empty() ||
       !(group_name == "Enabled" || group_name == "DefaultEnabled")) {
     // Mobile devices are using AECM.
     int err = audio_processing->echo_control_mobile()->set_routing_mode(
@@ skipping 100 matching lines @@
   int median = 0, std = 0;
   float dummy = 0;
   if (echo_cancellation->GetDelayMetrics(&median, &std, &dummy) ==
       webrtc::AudioProcessing::kNoError) {
     stats->echo_delay_median_ms = median;
     stats->echo_delay_std_ms = std;
   }
 }
 
 }  // namespace content