content/renderer/media/: Change when to populate WebRTC.AecDelayBasedQuality

content/renderer/media/: Change when to populate WebRTC.AecDelayBasedQuality

Previously the WebRTC.AecDelayBasedQuality histogram was populated even when the call to fetch the metrics from WebRTC failed. This CL makes sure we only populate upon success.

BUG=450193
Committed: https://crrev.com/162e126f60c0b5453680326423ecbc376f4e5a60
Cr-Commit-Position: refs/heads/master@{#322556}

[bjornv, 2015-03-26 17:53:08]

bjornv@chromium.org changed reviewers:
+ perkj@chromium.org

[bjornv, 2015-03-26 17:53:47]

Per, PTAL at this tiny fix of UMA stats.

[perkj_chrome, 2015-03-27 09:34:10]

This behaviour is up to you...

change lgtm

https://codereview.chromium.org/999203003/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor_options.cc (right):

https://codereview.chromium.org/999203003/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor_options.cc:255:
UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
So you no longer want to log when GetDelayMetrics fails?

[bjornv, 2015-03-27 10:01:53]

https://codereview.chromium.org/999203003/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor_options.cc (right):

https://codereview.chromium.org/999203003/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor_options.cc:255:
UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
On 2015/03/27 09:34:09, perkj wrote:
> So you no longer want to log when GetDelayMetrics fails? 

That's a good point. I'll remember that one if we're changing the behavior in
the future.
Anyhow, right now a failure is logged as "Great AEC quality", which actually is
unknown.

[bjornv, 2015-03-27 10:02:00]

The CQ bit was checked by bjornv@chromium.org

[commit-bot: I haz the power, 2015-03-27 10:02:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/999203003/1

[commit-bot: I haz the power, 2015-03-27 11:41:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-27 11:42:02]

Patchset 1 (id:??) landed as
https://crrev.com/162e126f60c0b5453680326423ecbc376f4e5a60
Cr-Commit-Position: refs/heads/master@{#322556}