Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 999193003: Add RoutingIDIssuer to help track routing id issues. (Closed)

Created:
5 years, 9 months ago by lfg
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is a re-land of https://codereview.chromium.org/643733002. This CL adds a RoutingIDIssuer that verifies that the routing IDs are being sent to the correct process. BUG=464633 TBR=sky@chromium.org Committed: https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1 Cr-Commit-Position: refs/heads/master@{#320207}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -4 lines) Patch
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 4 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
A content/browser/renderer_host/routing_id_issuer.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/browser/renderer_host/routing_id_issuer.cc View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A content/browser/renderer_host/routing_id_issuer_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A content/public/test/routing_id_mangling_disabler.h View 1 chunk +20 lines, -0 lines 0 comments Download
A content/public/test/routing_id_mangling_disabler.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
lfg
Hi nasko, please take a look. We should only keep this CL for one or ...
5 years, 9 months ago (2015-03-11 23:25:15 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-03-12 00:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999193003/60001
5 years, 9 months ago (2015-03-12 00:30:55 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-12 02:15:54 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1 Cr-Commit-Position: refs/heads/master@{#320207}
5 years, 9 months ago (2015-03-12 02:16:54 UTC) #7
lfg
5 years, 9 months ago (2015-03-19 16:48:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1019913002/ by lfg@chromium.org.

The reason for reverting is: We've already collected enough data to triage this
bug..

Powered by Google App Engine
This is Rietveld 408576698