Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: content/browser/renderer_host/render_widget_helper.h

Issue 999193003: Add RoutingIDIssuer to help track routing id issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_helper.h
diff --git a/content/browser/renderer_host/render_widget_helper.h b/content/browser/renderer_host/render_widget_helper.h
index 7f32035f2c68b6ed024016a1863ab99782929cb3..e8d7921949cb1acf91a74f7148076bfc9b5512e2 100644
--- a/content/browser/renderer_host/render_widget_helper.h
+++ b/content/browser/renderer_host/render_widget_helper.h
@@ -7,9 +7,9 @@
#include <map>
-#include "base/atomic_sequence_num.h"
#include "base/containers/hash_tables.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
#include "base/process/process.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
@@ -32,6 +32,7 @@ struct ViewMsg_SwapOut_Params;
namespace content {
class GpuProcessHost;
class ResourceDispatcherHostImpl;
+class RoutingIDIssuer;
class SessionStorageNamespace;
// Instantiated per RenderProcessHost to provide various optimizations on
@@ -79,6 +80,9 @@ class RenderWidgetHelper
// Gets the next available routing id. This is thread safe.
int GetNextRoutingID();
+ // Probablistically verify if the ID is issued by this helper.
+ // Thread safe.
+ bool IsRoutingIDProbablyValid(int routing_id) const;
// IO THREAD ONLY -----------------------------------------------------------
@@ -150,8 +154,7 @@ class RenderWidgetHelper
int render_process_id_;
- // The next routing id to use.
- base::AtomicSequenceNumber next_routing_id_;
+ scoped_ptr<RoutingIDIssuer> routing_id_issuer_;
ResourceDispatcherHostImpl* resource_dispatcher_host_;
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_widget_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698