Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 999173003: [turbofan] Remove indirection in JSToBoolean/JSUnaryNot lowering. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove indirection in JSToBoolean/JSUnaryNot lowering. This reduces the overhead of typed lowering, because we lower JSToBoolean/JSUnaryNot directly if possible, instead of first lowering to AnyToBoolean, and then letting the SimplifiedOperatorReducer do the further lowering. Also remove some obsolete tests from the cctest suite that have since been removed by proper unittests. And improve unitttest coverage for the typed lowering cases. R=mstarzinger@chromium.org Committed: https://crrev.com/a75e4cea8f454c6cdb71025903812689894cd8aa Cr-Commit-Position: refs/heads/master@{#27295}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -200 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +42 lines, -17 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 4 chunks +0 lines, -35 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +40 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-19 09:42:23 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-19 09:42:36 UTC) #2
Michael Starzinger
LGTM, I like it! https://codereview.chromium.org/999173003/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/999173003/diff/1/src/compiler/js-typed-lowering.cc#newcode543 src/compiler/js-typed-lowering.cc:543: // JSUnaryNot(x:string) => NumberEqual(x.length,#0) nit: ...
5 years, 9 months ago (2015-03-19 10:10:54 UTC) #3
Benedikt Meurer
Committed patchset #2 (id:20001) manually as a75e4cea8f454c6cdb71025903812689894cd8aa (presubmit successful).
5 years, 9 months ago (2015-03-19 10:13:20 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:13:22 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a75e4cea8f454c6cdb71025903812689894cd8aa
Cr-Commit-Position: refs/heads/master@{#27295}

Powered by Google App Engine
This is Rietveld 408576698