Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/compiler/verifier.cc

Issue 999173003: [turbofan] Remove indirection in JSToBoolean/JSUnaryNot lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 CheckUpperIs(node, Type::Any()); 550 CheckUpperIs(node, Type::Any());
551 break; 551 break;
552 552
553 case IrOpcode::kJSStackCheck: 553 case IrOpcode::kJSStackCheck:
554 // Type is empty. 554 // Type is empty.
555 CheckNotTyped(node); 555 CheckNotTyped(node);
556 break; 556 break;
557 557
558 // Simplified operators 558 // Simplified operators
559 // ------------------------------- 559 // -------------------------------
560 case IrOpcode::kAnyToBoolean:
561 // Type is Boolean.
562 CheckUpperIs(node, Type::Boolean());
563 break;
564 case IrOpcode::kBooleanNot: 560 case IrOpcode::kBooleanNot:
565 // Boolean -> Boolean 561 // Boolean -> Boolean
566 CheckValueInputIs(node, 0, Type::Boolean()); 562 CheckValueInputIs(node, 0, Type::Boolean());
567 CheckUpperIs(node, Type::Boolean()); 563 CheckUpperIs(node, Type::Boolean());
568 break; 564 break;
569 case IrOpcode::kBooleanToNumber: 565 case IrOpcode::kBooleanToNumber:
570 // Boolean -> Number 566 // Boolean -> Number
571 CheckValueInputIs(node, 0, Type::Boolean()); 567 CheckValueInputIs(node, 0, Type::Boolean());
572 CheckUpperIs(node, Type::Number()); 568 CheckUpperIs(node, Type::Number());
573 break; 569 break;
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 // Check inputs for all nodes in the block. 1059 // Check inputs for all nodes in the block.
1064 for (size_t i = 0; i < block->NodeCount(); i++) { 1060 for (size_t i = 0; i < block->NodeCount(); i++) {
1065 Node* node = block->NodeAt(i); 1061 Node* node = block->NodeAt(i);
1066 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 1062 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
1067 } 1063 }
1068 } 1064 }
1069 } 1065 }
1070 } 1066 }
1071 } 1067 }
1072 } // namespace v8::internal::compiler 1068 } // namespace v8::internal::compiler
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698