Source/core/layout/LayoutView.cpp - Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutView.cpp

Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add assert and allow CompositingClean change to InPreLayout Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutView.cpp

diff --git a/Source/core/layout/LayoutView.cpp b/Source/core/layout/LayoutView.cpp

index 6f78b62d2a3d951b85f995676a60e33b8caa4b2d..df2b76be985a245625a563307978a768e4eba8eb 100644

--- a/Source/core/layout/LayoutView.cpp

+++ b/Source/core/layout/LayoutView.cpp

@@ -97,7 +97,9 @@ bool LayoutView::hitTest(const HitTestRequest& request, const HitTestLocation& l

// Note that Document::updateLayout calls its parent's updateLayout.

// FIXME: It should be the caller's responsibility to ensure an up-to-date layout.

frameView()->updateLayoutAndStyleIfNeededRecursive();

+ compositor()->updateIfNeededRecursive();

commitPendingSelection();

+ ASSERT(document().lifecycle().state() >= DocumentLifecycle::CompositingClean);

leviw_travelin_and_unemployed 2015/03/12 20:09:32 This assert should go somewhere deeper in Blink, l

qiankun 2015/03/13 03:23:10 Done.

bool hitLayer = layer()->hitTest(request, location, result);

« Source/core/dom/DocumentLifecycle.cpp ('K') | « Source/core/dom/DocumentLifecycle.cpp ('k') | no next file » | no next file with comments »