Source/core/dom/DocumentLifecycle.cpp - Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing

Unified Diff: Source/core/dom/DocumentLifecycle.cpp

Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add assert and allow CompositingClean change to InPreLayout Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DocumentLifecycle.cpp

diff --git a/Source/core/dom/DocumentLifecycle.cpp b/Source/core/dom/DocumentLifecycle.cpp

index 59346de54fe7f197b9ed219f1e935cf1710852f8..c8c2439730dfd0464af826a49d759700536b6716 100644

--- a/Source/core/dom/DocumentLifecycle.cpp

+++ b/Source/core/dom/DocumentLifecycle.cpp

@@ -130,6 +130,8 @@ bool DocumentLifecycle::canAdvanceTo(State state) const

if (m_state == CompositingClean) {

if (state == InStyleRecalc)

return true;

+ if (state == InPreLayout)

leviw_travelin_and_unemployed 2015/03/12 20:09:32 Why this change?

qiankun 2015/03/13 03:23:10 When running layout test, LayoutTreeAsText::writeL

esprehn 2015/03/24 23:06:05 I think this is a bug in LayoutTreeAsText::writeLa

+ return true;

if (state == InCompositingUpdate)

return true;

if (state == InPaintInvalidation)

« no previous file with comments | « no previous file | Source/core/layout/LayoutView.cpp » ('j') | Source/core/layout/LayoutView.cpp » ('J')