Implementing closeSession from WebPresentationClient to PresentationService.

[PresentationAPI] Implementing CloseSession from WebPresentationClient to PresentationService.

Depends on the Blink change: https://codereview.chromium.org/1015903002

BUG=459007
Committed: https://crrev.com/ce6beecc2d99effe63337b637127b500c56219fd
Cr-Commit-Position: refs/heads/master@{#321278}

[haibinlu, 2015-03-18 21:10:10]

haibinlu@chromium.org changed reviewers:
+ avayvod@chromium.org, imcheng@chromium.org

[whywhat, 2015-03-19 01:05:27]

lgtm % my comment about the optionality of the presentation id in the Mojo
interface

https://codereview.chromium.org/999003004/diff/1/content/common/presentation/...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/999003004/diff/1/content/common/presentation/...
content/common/presentation/presentation_service.mojom:76: CloseSession(string
presentation_url, string? presentation_id);
I don't think the id is optional here. It will be either provided when calling
start/joinSession, or the UA will generate it. Did you intend to have a way to
close all sessions with the same URL?

[haibinlu, 2015-03-19 01:15:37]

https://codereview.chromium.org/999003004/diff/1/content/common/presentation/...
File content/common/presentation/presentation_service.mojom (right):

https://codereview.chromium.org/999003004/diff/1/content/common/presentation/...
content/common/presentation/presentation_service.mojom:76: CloseSession(string
presentation_url, string? presentation_id);
On 2015/03/19 01:05:27, whywhat wrote:
> I don't think the id is optional here. It will be either provided when calling
> start/joinSession, or the UA will generate it. Did you intend to have a way to
> close all sessions with the same URL? 

Right, it should not be optional. Updated.

[haibinlu, 2015-03-19 01:16:12]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2015-03-19 01:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/999003004/#ps20001 (title:
"Presentation ID is required when closing a session.")

[commit-bot: I haz the power, 2015-03-19 01:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/999003004/20001

[commit-bot: I haz the power, 2015-03-19 01:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 01:20:29]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haibinlu, 2015-03-19 01:33:54]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2015-03-19 01:33:55]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/999003004/#ps40001 (title:
"After merge")

[commit-bot: I haz the power, 2015-03-19 01:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/999003004/40001

[commit-bot: I haz the power, 2015-03-19 02:50:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 02:51:49]

Patchset 3 (id:??) landed as
https://crrev.com/ce6beecc2d99effe63337b637127b500c56219fd
Cr-Commit-Position: refs/heads/master@{#321278}