Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1015903002: [Presentation API] Adds close method to Presentation session. (Closed)

Created:
5 years, 9 months ago by haibinlu
Modified:
5 years, 9 months ago
Reviewers:
whywhat, imcheng
CC:
blink-reviews, dglazkov+blink, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding plumbing from the PresentationSession IDL implementation to the platform interface. This is part of a three-side change: 1. This (Blink) CL 2. Chromium CL: https://codereview.chromium.org/999003004/ 3. Cleanup: Making the new WebPresentationClient method pure virtual. BUG=459007 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192122

Patch Set 1 #

Total comments: 15

Patch Set 2 : Addresses whywhat's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M Source/modules/presentation/PresentationController.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationController.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationSession.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M Source/modules/presentation/PresentationSession.cpp View 1 3 chunks +16 lines, -2 lines 0 comments Download
M public/platform/modules/presentation/WebPresentationClient.h View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
haibinlu
5 years, 9 months ago (2015-03-17 22:34:07 UTC) #2
whywhat
Thanks for the change! Could you please add more information to the issue description? E.g. ...
5 years, 9 months ago (2015-03-17 23:35:19 UTC) #3
haibinlu
https://codereview.chromium.org/1015903002/diff/1/Source/modules/presentation/PresentationController.cpp File Source/modules/presentation/PresentationController.cpp (right): https://codereview.chromium.org/1015903002/diff/1/Source/modules/presentation/PresentationController.cpp#newcode109 Source/modules/presentation/PresentationController.cpp:109: if (!m_client) { On 2015/03/17 23:35:19, whywhat wrote: > ...
5 years, 9 months ago (2015-03-18 00:58:23 UTC) #4
whywhat
lgtm https://codereview.chromium.org/1015903002/diff/1/Source/modules/presentation/PresentationController.cpp File Source/modules/presentation/PresentationController.cpp (right): https://codereview.chromium.org/1015903002/diff/1/Source/modules/presentation/PresentationController.cpp#newcode112 Source/modules/presentation/PresentationController.cpp:112: m_client->closeSession(presentationId); On 2015/03/18 00:58:22, haibinlu wrote: > On ...
5 years, 9 months ago (2015-03-18 12:51:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015903002/20001
5 years, 9 months ago (2015-03-18 21:15:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 22:51:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192122

Powered by Google App Engine
This is Rietveld 408576698