Oilpan: use a cross-thread persistent for per-isolate ScriptDebugServers.

Oilpan: use a cross-thread persistent for per-isolate ScriptDebugServers.

TBR=oilpan-reviews
BUG=462572
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191735

[sof, 2015-03-11 21:23:26]

please take a look.

[sof, 2015-03-11 21:23:31]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-03-11 21:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998933004/1

[commit-bot: I haz the power, 2015-03-11 21:24:24]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191735

[haraken, 2015-03-11 23:13:49]

LGTM

Just curious, but how did you notice the error? (i.e., was it easy to detect the
error?)

[sof, 2015-03-12 09:30:17]

On 2015/03/11 23:13:49, haraken wrote:
> LGTM
> 
> Just curious, but how did you notice the error? (i.e., was it easy to detect
the
> error?)

It was, unfortunately -- all heap unit tests broke; the breakages yesterday made
for a bumpy ride.

The checkThread() assert in ThreadLocalPersistents::Lock::Lock() caught that the
main thread was destructing these persistents.