Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 998933004: Oilpan: use a cross-thread persistent for per-isolate ScriptDebugServers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/Source/bindings/core/v8/V8PerIsolateData.cpp b/Source/bindings/core/v8/V8PerIsolateData.cpp
index 476bb2c3da01efeddc8826309ecb4aaa06bebee9..96a7c99d7eeb44c6ddc759b969092988225a31f5 100644
--- a/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -77,6 +77,7 @@ V8PerIsolateData::V8PerIsolateData()
, m_internalScriptRecursionLevel(0)
#endif
, m_performingMicrotaskCheckpoint(false)
+ , m_debugServer(nullptr)
{
// FIXME: Remove once all v8::Isolate::GetCurrent() calls are gone.
isolate()->Enter();
@@ -141,6 +142,7 @@ void V8PerIsolateData::destroy(v8::Isolate* isolate)
V8PerIsolateData* data = from(isolate);
// FIXME: Remove once all v8::Isolate::GetCurrent() calls are gone.
isolate->Exit();
+ data->m_debugServer.clear();
delete data;
}
« no previous file with comments | « Source/bindings/core/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698