Enable dartanalyze warnings.

Enable dartanalyze warnings.

This cleans up all the warnings in the mojo dart code, and enables the
checking of warnings in the build.

BUG=459376
R=zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/3c267884ddc1cd47b118c53c0c92d0c821e0ff25

[Elliot Glaysher, 2015-03-11 17:31:34]

erg@chromium.org changed reviewers:
+ zra@google.com

[zra, 2015-03-11 18:38:06]

https://codereview.chromium.org/998693004/diff/20001/mojo/public/dart/src/han...
File mojo/public/dart/src/handle.dart (right):

https://codereview.chromium.org/998693004/diff/20001/mojo/public/dart/src/han...
mojo/public/dart/src/handle.dart:47: throw "Unexpected result $mwr.result for
wait on $h";
Either $mwr or ${mwr.result}

https://codereview.chromium.org/998693004/diff/20001/mojo/public/dart/src/mes...
File mojo/public/dart/src/message_pipe.dart (right):

https://codereview.chromium.org/998693004/diff/20001/mojo/public/dart/src/mes...
mojo/public/dart/src/message_pipe.dart:85: return new
MojoMessagePipeReadResult(status, 0, 0);
null

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
File services/dart/test/pingpong/main.dart (right):

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong/main.dart:55: [Function responseFactory = null])
async {
default is already null when not specified.

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong/main.dart:77: [Function responseFactory = null])
async {
ditto

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
File services/dart/test/pingpong_target/main.dart (right):

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong_target/main.dart:30: String url, int count,
[Function responseFactory = null]) =>
ditto

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong_target/main.dart:33: Object service, int count,
[Function responseFactory = null]) =>
ditto

[Elliot Glaysher, 2015-03-11 19:19:18]

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
File services/dart/test/pingpong/main.dart (right):

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong/main.dart:55: [Function responseFactory = null])
async {
On 2015/03/11 18:38:06, zra wrote:
> default is already null when not specified.

I am unsure what resolution you're asking for here. I've speculatively removed '
= null' from every case that you mentioned. If that's not the correct resolution
here, please be specific in you're followup comments.

[zra, 2015-03-11 19:32:57]

lgtm

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
File services/dart/test/pingpong/main.dart (right):

https://codereview.chromium.org/998693004/diff/20001/services/dart/test/pingp...
services/dart/test/pingpong/main.dart:55: [Function responseFactory = null])
async {
On 2015/03/11 19:19:18, Elliot Glaysher wrote:
> On 2015/03/11 18:38:06, zra wrote:
> > default is already null when not specified.
> 
> I am unsure what resolution you're asking for here. I've speculatively removed
'
> = null' from every case that you mentioned. If that's not the correct
resolution
> here, please be specific in you're followup comments.

Ah, yes. Sorry for not being more explicit.

[Elliot Glaysher, 2015-03-11 19:40:44]

Committed patchset #3 (id:40001) manually as
3c267884ddc1cd47b118c53c0c92d0c821e0ff25 (presubmit successful).