Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: mojo/public/dart/src/message_pipe.dart

Issue 998693004: Enable dartanalyze warnings. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Rebase to ToT Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 part of core; 5 part of core;
6 6
7 class _MojoMessagePipeNatives { 7 class _MojoMessagePipeNatives {
8 static List MojoCreateMessagePipe(int flags) native "MojoMessagePipe_Create"; 8 static List MojoCreateMessagePipe(int flags) native "MojoMessagePipe_Create";
9 9
10 static int MojoWriteMessage(int handle, ByteData data, int numBytes, 10 static int MojoWriteMessage(int handle, ByteData data, int numBytes,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 75 }
76 76
77 // If numBytes has the default value, use the full length of the data. 77 // If numBytes has the default value, use the full length of the data.
78 int dataNumBytes; 78 int dataNumBytes;
79 if (data == null) { 79 if (data == null) {
80 dataNumBytes = 0; 80 dataNumBytes = 0;
81 } else { 81 } else {
82 dataNumBytes = (numBytes == -1) ? data.lengthInBytes : numBytes; 82 dataNumBytes = (numBytes == -1) ? data.lengthInBytes : numBytes;
83 if (dataNumBytes > data.lengthInBytes) { 83 if (dataNumBytes > data.lengthInBytes) {
84 status = MojoResult.INVALID_ARGUMENT; 84 status = MojoResult.INVALID_ARGUMENT;
85 return status; 85 return new MojoMessagePipeReadResult(status, 0, 0);
zra 2015/03/11 18:38:06 null
86 } 86 }
87 } 87 }
88 88
89 // handles may be null, otherwise make an int list for the handles. 89 // handles may be null, otherwise make an int list for the handles.
90 List<int> mojoHandles; 90 List<int> mojoHandles;
91 if (handles == null) { 91 if (handles == null) {
92 mojoHandles = null; 92 mojoHandles = null;
93 } else { 93 } else {
94 mojoHandles = new List<int>(handles.length); 94 mojoHandles = new List<int>(handles.length);
95 } 95 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 MojoHandle end1 = new MojoHandle(result[1]); 149 MojoHandle end1 = new MojoHandle(result[1]);
150 MojoHandle end2 = new MojoHandle(result[2]); 150 MojoHandle end2 = new MojoHandle(result[2]);
151 MojoMessagePipe pipe = new MojoMessagePipe._(); 151 MojoMessagePipe pipe = new MojoMessagePipe._();
152 pipe.endpoints = new List(2); 152 pipe.endpoints = new List(2);
153 pipe.endpoints[0] = new MojoMessagePipeEndpoint(end1); 153 pipe.endpoints[0] = new MojoMessagePipeEndpoint(end1);
154 pipe.endpoints[1] = new MojoMessagePipeEndpoint(end2); 154 pipe.endpoints[1] = new MojoMessagePipeEndpoint(end2);
155 pipe.status = new MojoResult(result[0]); 155 pipe.status = new MojoResult(result[0]);
156 return pipe; 156 return pipe;
157 } 157 }
158 } 158 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698