Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 998673002: Add [NewObject] and [SameObject] to various interfaces (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [NewObject] and [SameObject] to various interfaces This only updates interfaces which have already been touched as part of "Sync IDL files with specs", many interfaces remain to be sync'd. BUG=460722, 462913 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -47 lines) Patch
M Source/core/dom/DOMImplementation.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.idl View 4 chunks +21 lines, -25 lines 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/MutationRecord.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Window.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-10 18:35:14 UTC) #2
Jens Widell
LGTM
5 years, 9 months ago (2015-03-10 18:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998673002/1
5 years, 9 months ago (2015-03-11 03:22:19 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 03:25:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191675

Powered by Google App Engine
This is Rietveld 408576698