Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: Source/core/dom/Document.idl

Issue 998673002: Add [NewObject] and [SameObject] to various interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/DOMImplementation.idl ('k') | Source/core/dom/Element.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index 63064e608eb6e8639b45b522b0e470e8084d808c..f6c00071b33316ab5b0a689614b9e5ea4f4ce67a 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -29,7 +29,7 @@ enum VisibilityState { "hidden", "visible", "prerender", "unloaded" };
// FIXME: Document should have a constructor.
interface Document : Node {
- readonly attribute DOMImplementation implementation;
+ [SameObject] readonly attribute DOMImplementation implementation;
readonly attribute DOMString URL;
// FIXME: documentURI should not be nullable.
[ImplementedAs=url] readonly attribute DOMString? documentURI;
@@ -47,31 +47,27 @@ interface Document : Node {
HTMLCollection getElementsByTagNameNS(DOMString? namespaceURI, DOMString localName);
HTMLCollection getElementsByClassName(DOMString classNames);
- [CustomElementCallbacks, PerWorldBindings, RaisesException] Element createElement(DOMString localName);
- [CustomElementCallbacks, RaisesException] Element createElementNS(DOMString? namespaceURI, DOMString qualifiedName);
- DocumentFragment createDocumentFragment();
- Text createTextNode(DOMString data);
- Comment createComment(DOMString data);
- [RaisesException] ProcessingInstruction createProcessingInstruction(DOMString target, DOMString data);
+ [NewObject, CustomElementCallbacks, PerWorldBindings, RaisesException] Element createElement(DOMString localName);
+ [NewObject, CustomElementCallbacks, RaisesException] Element createElementNS(DOMString? namespaceURI, DOMString qualifiedName);
+ [NewObject] DocumentFragment createDocumentFragment();
+ [NewObject] Text createTextNode(DOMString data);
+ [NewObject] Comment createComment(DOMString data);
+ [NewObject, RaisesException] ProcessingInstruction createProcessingInstruction(DOMString target, DOMString data);
- [CustomElementCallbacks, RaisesException, TypeChecking=Interface] Node importNode(Node node, optional boolean deep = false);
+ [NewObject, CustomElementCallbacks, RaisesException, TypeChecking=Interface] Node importNode(Node node, optional boolean deep = false);
[RaisesException, CustomElementCallbacks, TypeChecking=Interface] Node adoptNode(Node node);
- [RaisesException, MeasureAs=DocumentCreateAttribute] Attr createAttribute(DOMString localName);
+ [NewObject, RaisesException, MeasureAs=DocumentCreateAttribute] Attr createAttribute(DOMString localName);
// FIXME: qualifiedName should not be nullable.
- [RaisesException, MeasureAs=DocumentCreateAttributeNS] Attr createAttributeNS(DOMString? namespaceURI, DOMString? qualifiedName);
+ [NewObject, RaisesException, MeasureAs=DocumentCreateAttributeNS] Attr createAttributeNS(DOMString? namespaceURI, DOMString? qualifiedName);
- [RaisesException] Event createEvent(DOMString eventType);
+ [NewObject, RaisesException] Event createEvent(DOMString eventType);
- Range createRange();
+ [NewObject] Range createRange();
// NodeFilter.SHOW_ALL = 0xFFFFFFFF
- [RaisesException, TypeChecking=Interface] NodeIterator createNodeIterator(Node root,
- optional unsigned long whatToShow = 0xFFFFFFFF,
- optional NodeFilter? filter = null);
- [RaisesException, TypeChecking=Interface] TreeWalker createTreeWalker(Node root,
- optional unsigned long whatToShow = 0xFFFFFFFF,
- optional NodeFilter? filter = null);
+ [NewObject, RaisesException, TypeChecking=Interface] NodeIterator createNodeIterator(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null);
+ [NewObject, RaisesException, TypeChecking=Interface] TreeWalker createTreeWalker(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null);
// FIXME: CDATASection has been removed from the spec. crbug.com/437205
[RaisesException, MeasureAs=DocumentCreateCDATASection] CDATASection createCDATASection(DOMString data);
@@ -102,12 +98,12 @@ interface Document : Node {
[TreatNullAs=NullString, CustomElementCallbacks] attribute DOMString dir;
[RaisesException=Setter, CustomElementCallbacks, PerWorldBindings, TypeChecking=Interface, ExposeJSAccessors] attribute HTMLElement? body;
readonly attribute HTMLHeadElement? head;
- readonly attribute HTMLCollection images;
- readonly attribute HTMLCollection embeds;
- [ImplementedAs=embeds] readonly attribute HTMLCollection plugins;
- readonly attribute HTMLCollection links;
- readonly attribute HTMLCollection forms;
- readonly attribute HTMLCollection scripts;
+ [SameObject] readonly attribute HTMLCollection images;
+ [SameObject] readonly attribute HTMLCollection embeds;
+ [SameObject, ImplementedAs=embeds] readonly attribute HTMLCollection plugins;
+ [SameObject] readonly attribute HTMLCollection links;
+ [SameObject] readonly attribute HTMLCollection forms;
+ [SameObject] readonly attribute HTMLCollection scripts;
[PerWorldBindings] NodeList getElementsByName(DOMString elementName);
readonly attribute HTMLScriptElement? currentScript;
@@ -143,7 +139,7 @@ interface Document : Node {
// CSS Object Model (CSSOM)
// http://dev.w3.org/csswg/cssom/#extensions-to-the-document-interface
- readonly attribute StyleSheetList styleSheets;
+ [SameObject] readonly attribute StyleSheetList styleSheets;
attribute DOMString? selectedStylesheetSet;
readonly attribute DOMString? preferredStylesheetSet;
« no previous file with comments | « Source/core/dom/DOMImplementation.idl ('k') | Source/core/dom/Element.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698