chrome.platformKeys.getKeyPair: Check requested algorithm against certificate.

chrome.platformKeys.getKeyPair: Check requested algorithm against certificate.

This adds a check that the requested algorithm is actually permitted by the certificate as defined in the algorithm field of the Subject Public Key Info.

BUG=466584
Committed: https://crrev.com/80709e2614a1530449e0aacb67d85f5b6d8a5db5
Cr-Commit-Position: refs/heads/master@{#322142}

[pneubeck (no reviews), 2015-03-12 15:19:20]

pneubeck@chromium.org changed reviewers:
+ bartfab@chromium.org

[pneubeck (no reviews), 2015-03-12 15:19:21]

ptal, this change depends on the other one.

[pneubeck (no reviews), 2015-03-16 17:44:11]

pneubeck@chromium.org changed reviewers:
+ atwilson@chromium.org
- bartfab@chromium.org

[pneubeck (no reviews), 2015-03-16 17:44:12]

changing reviewer.
ptal at this second.

[Andrew T Wilson (Slow), 2015-03-19 07:38:13]

LGTM with a few nits.

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/platform_keys/platform_keys_api.cc (right):

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/platform_keys/platform_keys_api.cc:28: "The
requested Algorithm is not permitted by Certificate.";
by Certificate or "by the Certificate"?

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/platform_keys/platform_keys_api.cc:129: // The
currently only supported combination is:
nit: "The only currently supported" or "Currently, the only supported"

https://codereview.chromium.org/998293002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/platform_keys_internal.idl (right):

https://codereview.chromium.org/998293002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/platform_keys_internal.idl:52: // of the WebCrypto
algorithm <code>algorithmName</code>. If so, calls back
Maybe document what happens if there is no allowable key? I guess the callback
is not invoked and it just silently fails?

[pneubeck (no reviews), 2015-03-23 13:43:12]

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/platform_keys/platform_keys_api.cc (right):

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/platform_keys/platform_keys_api.cc:28: "The
requested Algorithm is not permitted by Certificate.";
On 2015/03/19 07:38:12, Andrew T Wilson wrote:
> by Certificate or "by the Certificate"?

Done.

https://codereview.chromium.org/998293002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/platform_keys/platform_keys_api.cc:129: // The
currently only supported combination is:
On 2015/03/19 07:38:12, Andrew T Wilson wrote:
> nit: "The only currently supported" or "Currently, the only supported"

Done.

https://codereview.chromium.org/998293002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/platform_keys_internal.idl (right):

https://codereview.chromium.org/998293002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/platform_keys_internal.idl:52: // of the WebCrypto
algorithm <code>algorithmName</code>. If so, calls back
On 2015/03/19 07:38:12, Andrew T Wilson wrote:
> Maybe document what happens if there is no allowable key? I guess the callback
> is not invoked and it just silently fails?

Error handling for extension APIs is very standardized: callback is called with
chrome.runtime.lastError set.
I added a comment that an errors is thrown.

[pneubeck (no reviews), 2015-03-23 13:44:33]

pneubeck@chromium.org changed reviewers:
+ kalman@chromium.org

[pneubeck (no reviews), 2015-03-23 13:44:34]

Hi Benjamin,
I need an owner review for
  platform_keys_internal.idl
and the
  platform_keys_custom_binding.js

[pneubeck (no reviews), 2015-03-24 09:44:39]

pneubeck@chromium.org changed reviewers:
+ rockot@chromium.org
- kalman@chromium.org

[pneubeck (no reviews), 2015-03-24 09:44:40]

Hi Ken,
I need an owner review for
  platform_keys_internal.idl
and the
  platform_keys_custom_binding.js

Drew already looked at all changes.

[Ken Rockot(use gerrit already), 2015-03-24 16:53:44]

On 2015/03/24 09:44:40, pneubeck wrote:
> Hi Ken,
> I need an owner review for
>   platform_keys_internal.idl
> and the
>   platform_keys_custom_binding.js
> 
> Drew already looked at all changes.

lgtm

[pneubeck (no reviews), 2015-03-24 17:01:13]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2015-03-24 17:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/998293002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-03-24 17:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998293002/20001

[commit-bot: I haz the power, 2015-03-24 18:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 18:20:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pneubeck (no reviews), 2015-03-25 09:51:20]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2015-03-25 09:51:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/998293002/#ps40001 (title:
"Fix string in test.")

[commit-bot: I haz the power, 2015-03-25 09:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998293002/40001

[commit-bot: I haz the power, 2015-03-25 12:02:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-25 12:03:26]

Patchset 3 (id:??) landed as
https://crrev.com/80709e2614a1530449e0aacb67d85f5b6d8a5db5
Cr-Commit-Position: refs/heads/master@{#322142}