chrome.platformKeys.getKeyPair: Check requested algorithm against certificate.

chrome/common/extensions/api/platform_keys_internal.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Internal API for to implement the platformKeys and enterprise.platformKeys
 // APIs.
-[ implemented_in = "chrome/browser/extensions/api/platform_keys/platform_keys_api.h" ]
+[implemented_in = "chrome/browser/extensions/api/platform_keys/platform_keys_api.h"]
 namespace platformKeysInternal {
   callback SelectCallback = void (platformKeys.Match[] certs);
 
   // Invoked by <code>sign</code>.
   // |signature| The signature, a octet string.
   callback SignCallback = void(ArrayBuffer signature);
 
   // Called back by <code>getPublicKey</code>.
   // |publicKey| The Subject Public Key Info (see X.509) of the requested
   //   certificate.
@@ skipping 23 matching lines @@
     // |data| The data to sign.
     // |callback| Called back with the signature of |data|.
     // TODO: Instead of ArrayBuffer should be (ArrayBuffer or ArrayBufferView),
     // or at least (ArrayBuffer or Uint8Array).
     static void sign(DOMString tokenId,
                      ArrayBuffer publicKey,
                      DOMString hashAlgorithmName,
                      ArrayBuffer data,
                      SignCallback callback);
 
-    // Calls back <code>callback</code> with details about the key certified by
-    // <code>certificate</code>.
+    // Checks whether <code>certificate</code> certifies a key that allows usage
+    // of the WebCrypto algorithm <code>algorithmName</code>. If so, calls back

[Andrew T Wilson (Slow), 2015/03/19 07:38:12]

Maybe document what happens if there is no allowable key? I guess the callback
is not invoked and it just silently fails?

[pneubeck (no reviews), 2015/03/23 13:43:12]

Error handling for extension APIs is very standardized: callback is called with
chrome.runtime.lastError set.
I added a comment that an errors is thrown.

+    // <code>callback</code> with the key info and a WebCrypto
+    // <code>KeyAlgorithm</code> dictionary describing the key's algorithm. The
+    // <code>name</code> property will equal <code>algorithmName</code>.
     static void getPublicKey(ArrayBuffer certificate,
+                             DOMString algorithmName,
                              GetPublicKeyCallback callback);
   };
 };