src/conversions.cc - Issue 998213002: add 0 length guard in IsNonArrayIndexInteger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions.cc

Issue 998213002: add 0 length guard in IsNonArrayIndexInteger (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/conversions.cc

diff --git a/src/conversions.cc b/src/conversions.cc

index 31e8b1b01a5496c50d9086b21a50cf26a637d737..82a521bd90844775746707cd529f5535ebb912a7 100644

--- a/src/conversions.cc

+++ b/src/conversions.cc

@@ -509,7 +509,7 @@ bool IsNonArrayIndexInteger(String* string) {

uint16_t buffer[kBufferSize];

int offset = 0;

const int length = string->length();

- DCHECK_NE(0, length);

+ if (length == 0) return false;

// First iteration, check for minus, 0 followed by anything else, etc.

int to = std::min(offset + kUint32MaxChars, length);

{

« no previous file with comments | « no previous file | test/cctest/test-conversions.cc » ('j') | no next file with comments »