test/cctest/test-conversions.cc - Issue 998213002: add 0 length guard in IsNonArrayIndexInteger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-conversions.cc

Issue 998213002: add 0 length guard in IsNonArrayIndexInteger (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-conversions.cc

diff --git a/test/cctest/test-conversions.cc b/test/cctest/test-conversions.cc

index c8b87d8989a56e0e3382880164a412c8d6f9285d..789425119d5b90bd8a6c8f2e4e7bb08229e6eed1 100644

--- a/test/cctest/test-conversions.cc

+++ b/test/cctest/test-conversions.cc

@@ -374,6 +374,7 @@ static void CheckNonArrayIndex(bool expected, const char* chars) {

TEST(NonArrayIndexParsing) {

auto isolate = CcTest::i_isolate();

HandleScope scope(isolate);

+ CheckNonArrayIndex(false, "");

CheckNonArrayIndex(false, "-");

CheckNonArrayIndex(false, "0");

CheckNonArrayIndex(false, "01");

« no previous file with comments | « src/conversions.cc ('k') | no next file » | no next file with comments »